Allow $options['fieldList'] to be mangled/modified inside beforeValidate(). #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We will need a test or this and one that involves behaviors |
|
Roger, I'll do that. |
| @@ -247,7 +247,7 @@ public function validateMany(&$data, $options = array()) { | |||
| * @see ModelValidator::validates() | |||
| */ | |||
| public function errors($options = array()) { | |||
| if (!$this->_triggerBeforeValidate($options)) { | |||
| if (!$this->_triggerBeforeValidate(&$options)) { | |||
There was a problem hiding this comment.
from: http://php.net/manual/en/language.references.pass.php
There is no reference sign on a function call - only on function definitions.
There was a problem hiding this comment.
Thanks ceeram! you are right.
|
"Call-time pass-by-reference" errors 😄 |
|
This can't be done this way, as @ceeram correctly states, the reference sign should be set in the function definition, and to achieve this, Maybe it is "the way" but its more complicated than this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now,
ModelValidator::errors()triggersModelValidator::_triggerBeforeValidate()with a copy of$options.Later,
ModelValidator::_triggerBeforeValidate()dispatches an event with those options, but if modified insideModel::beforeValidate()they are never updated insideModelValidator::errors(), where actual validation occurs.This is handy when needing to update $fieldList after a
Model::save()is triggered.